Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: quic: use smallvec to aggregate chunks, save 1 alloc per packet (backport of #735) #741

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 11, 2024

Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet.


This is an automatic backport of pull request #735 done by Mergify.

Copy link
Author

mergify bot commented Apr 11, 2024

Cherry-pick of 55ab7fa has failed:

On branch mergify/bp/v1.17/pr-735
Your branch is up to date with 'origin/v1.17'.

You are currently cherry-picking commit 55ab7fadbc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   Cargo.lock
	both modified:   Cargo.toml
	both modified:   programs/sbf/Cargo.lock
	both modified:   streamer/Cargo.toml
	both modified:   streamer/src/nonblocking/quic.rs

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

quic: use smallvec, save one allocation per packet

Use smallvec to hold chunks. Streams are packet-sized so we don't expect
them to have many chunks. This saves us an allocation for each packet.

(cherry picked from commit 55ab7fa)

# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	programs/sbf/Cargo.lock
#	streamer/Cargo.toml
#	streamer/src/nonblocking/quic.rs
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.6%. Comparing base (be83469) to head (0dc42a4).
Report is 2 commits behind head on v1.17.

Additional details and impacted files
@@           Coverage Diff           @@
##            v1.17     #741   +/-   ##
=======================================
  Coverage    81.6%    81.6%           
=======================================
  Files         806      806           
  Lines      219284   219283    -1     
=======================================
+ Hits       179014   179079   +65     
+ Misses      40270    40204   -66     

@t-nelson t-nelson merged commit fec4fd6 into v1.17 Apr 11, 2024
33 checks passed
@t-nelson t-nelson deleted the mergify/bp/v1.17/pr-735 branch April 11, 2024 16:36
@steviez
Copy link

steviez commented Apr 11, 2024

Missed the pre-merge review, but this looks good to me

@behzadnouri
Copy link

Was there any testing done here that this backport to stable branch was necessary?
Like if it moves a needle or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants