Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockstore: Move BlockstoreError to separate file #4763

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

steviez
Copy link

@steviez steviez commented Feb 3, 2025

Problem

The BlockstoreError type lives in blockstore_db.rs which is currently a bit of a junk drawer

Summary of Changes

Work towards better organization by moving BlockstoreError (and the related Result) to their own file

Copy link

mergify bot commented Feb 3, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @steviez.

@steviez
Copy link
Author

steviez commented Feb 3, 2025

If this PR represents a change to the public RPC API:

No change to RPC API, just importing the type from the more "public" location

@steviez steviez merged commit c3a40f5 into anza-xyz:master Feb 4, 2025
47 checks passed
@steviez steviez deleted the bstore_split_error branch February 4, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants