Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump tokio-util to 0.7.13 #4745

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

yihau
Copy link
Member

@yihau yihau commented Feb 3, 2025

Summary of Changes

bump it

@yihau yihau requested a review from KirillLykov February 3, 2025 09:32
@KirillLykov
Copy link

KirillLykov commented Feb 3, 2025

Bumping this version would allow to use some new features of this crate, simplifying the code. The one I use is that cancellation token now has method https://docs.rs/tokio-util/latest/tokio_util/sync/struct.CancellationToken.html#method.run_until_cancelled

Why it is better to specify full version rather than minor like it was -- in some CI checks cargo pick ups version 0.7.13 (last one) but sometimes it picks 0.7.11 which doesn't have some methods.

There is a very low risk of breaking something with bumping the version because this crate contains limited functionality and because the changes between 11 and 13 are quite minimal (but simplifying life as I said).

@yihau yihau merged commit 8102577 into anza-xyz:master Feb 3, 2025
58 checks passed
@KirillLykov KirillLykov added the v2.1 Backport to v2.1 branch label Feb 3, 2025
Copy link

mergify bot commented Feb 3, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Feb 3, 2025
@yihau yihau deleted the bump-tokio-util branch February 6, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.1 Backport to v2.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants