Remove cond_var in verification_complete at startup #3507
+16
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoranYi
force-pushed
the
remove_cond_var
branch
from
c34e0ed
to
e85bb92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
WaitableCondVarinVerifyAccountsHashInBackgroundstruct at startup is no longer needed. We no longer block the main thread during hash verification. And the only call on the cond_var is wait_for_timeout with duration of zero, which doesn't block at all. And this wait is unnecessary, since we can know if the background process has completed from another atomic variable 'background_completed`.Summary of Changes
Remove cond_var in
VerifyAccountsHashInBackgroundFixes #