Remove Blockstore fifo compaction code #3469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Use of fifo compaction (via
--rocksdb-shred-compaction fifo
) has been deprecated.fifo
at the CLI levelfifo
can't be set, the code to handlefifo
is still presently in the codebaseSummary of Changes
Since
fifo
is no longer a valid option, we can remove all of the code that configures it / handles choosing between level and fifo (since level is the only choice now)