Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic processing pipeline #3467

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

apfitzge
Copy link

@apfitzge apfitzge commented Nov 4, 2024

Problem

  • To allow new transaction type, we need to switch types (or make generic) in our processing pipeline

Summary of Changes

  • Make (as much as reasonably possible at this time) the processing pipeline generic

Fixes #

@apfitzge apfitzge self-assigned this Nov 4, 2024
@apfitzge
Copy link
Author

apfitzge commented Nov 6, 2024

From here, block-verification (replay) and block-production (banking) can be made generic independently.

@apfitzge apfitzge marked this pull request as ready for review November 6, 2024 20:18
@jstarry
Copy link

jstarry commented Nov 6, 2024

Is it necessary to have SVMTransactionAdapter? Can't we add those methods to SVMTransaction instead?

@apfitzge
Copy link
Author

apfitzge commented Nov 6, 2024

Is it necessary to have SVMTransactionAdapter? Can't we add those methods to SVMTransaction instead?

SVMTransaction is meant to be stuff necessary for svm. converting into our legacy formats for our internal/plugin interfaces elsewhere isn't necessary for that.

The goal is for SVMTransactionAdapter to go away eventually, as our interfaces become better. It just needs to exist until those change, but changing the interfaces involves breaking geyser plugins - so it will not happen immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants