Extract reserved-account-keys and sdk-ids crates

[kevinheavey]

Problem

• solana_sdk::reserved_account_keys blocks moving out solana_sdk::transaction
• It would be good to be able to use important program IDs without importing heavy dependencies or inlining them

Summary of Changes

• Extract reserved-account-keys-crate and re-export for backwards compatibility
• For every ID definition imported by reserved-account-keys, move that definition to solana-sdk-ids and re-export it where it used to be

This branches off #3140 so that needs to be merged first

[mergify]

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

[kevinheavey]

This might be cleaner as two separate crates? One that just contains the ID declarations (perhaps solana-sdk-ids) and another containing ReservedAccountKeys &co.

This would avoid having to do all the feature and target_os stuff that ended up being uglier than I expected.

@joncinque thoughts?

[kevinheavey]

This might be cleaner as two separate crates? One that just contains the ID declarations (perhaps solana-sdk-ids

I see there is already a deprecated solana_program::sdk_ids module so the name would clash. But no other name comes to mind and it wouldn't be the worst thing to clash with

[kevinheavey]

Ok ended up having no choice but to make it two crates because there was a circular dependency when everything was in reserved-account-keys

[joncinque]

Looks great to me! Just one little point for stake::program

[joncinque]

I went back and forth on other possible names for the crate, but solana-sdk-ids seems like the clearest

[joncinque]

Out of curiosity, does this crate negatively impact build times on the crates that re-export it? Or is the macro quick?

[kevinheavey]

Based on running cargo build -r on solana-sysvar-id ten times each for this branch and the master branch, the increase in build time is 0.05 seconds on my machine. And that's the worst case because solana-sysvar-id gets blocked waiting for solana-sdk-ids to compile

[joncinque]

Looks good to me! @yihau can you accept solana-sdk-ids and solana-reserved-account-keys?