Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract account-utils crate #3083

Closed
wants to merge 1 commit into from
Closed

extract account-utils crate #3083

wants to merge 1 commit into from

Conversation

kevinheavey
Copy link

Problem

solana_sdk::account_utils imposes a solana_sdk dep on solana-rpc-client-nonce-utils

Summary of Changes

Move to its own crate and re-export with deprecation

This branches off #2294 so that needs to be merged first

@kevinheavey kevinheavey mentioned this pull request Oct 5, 2024
Open
@kevinheavey kevinheavey force-pushed the account-utils-crate branch 2 times, most recently from 04ed5cb to 7ce6203 Compare October 7, 2024 21:21
@kevinheavey kevinheavey marked this pull request as ready for review October 8, 2024 12:09
joncinque
joncinque reviewed Oct 15, 2024
View reviewed changes
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than creating a new crate for these traits, is there a big drawback to moving these into the solana-account crate, gated by the bincode feature? We could move them to a file called traits.rs or state.rs, which I think would be clearest.

@kevinheavey
Copy link
Author

Closing in favour of #3174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque left review comments

Assignees
No one assigned
Labels
need:merge-assist
Projects
SDK Breakup + Breakout
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinheavey @joncinque