Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.18: ci: ignore the tonic audit as a temporary stopgap (backport of #3052) #3062

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 3, 2024

Problem

I'm too naive. #3050 will take some time to upgrade. use this quick fix for unblocking master asap

Summary of Changes

ignore tonic audit report temporarily


This is an automatic backport of pull request #3052 done by [Mergify](https://mergify.com).

(cherry picked from commit 9b5525d)

# Conflicts:
#	ci/do-audit.sh
@mergify mergify bot added the conflicts label Oct 3, 2024
@mergify mergify bot requested a review from a team as a code owner October 3, 2024 21:41
Copy link
Author

mergify bot commented Oct 3, 2024

Cherry-pick of 9b5525d has failed:

On branch mergify/bp/v1.18/pr-3052
Your branch is up to date with 'origin/v1.18'.

You are currently cherry-picking commit 9b5525d127.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ci/do-audit.sh

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot assigned yihau Oct 3, 2024
@willhickey willhickey requested a review from yihau October 3, 2024 21:44
@willhickey
Copy link

Need to tag another v1.18 release but it won't build without this change

@willhickey willhickey merged commit 92ddaa2 into v1.18 Oct 4, 2024
16 checks passed
@willhickey willhickey deleted the mergify/bp/v1.18/pr-3052 branch October 4, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants