Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: make find-program-derived-address print bump seed in verbose display #3042

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

syjcnss
Copy link

@syjcnss syjcnss commented Sep 30, 2024

Problem

The find-program-derived-address command doesn't print the bump seed, which could be useful.

$ solana find-program-derived-address -v 11111111111111111111111111111111 "string:HELLO"
Seeds: [[72, 69, 76, 76, 79]]
4U64rfZFeEwSRmQdsNtMNRZtCD6w9b2QhrXgZzUoCDi6

Summary of Changes

This commit make it prints bump seed in verbose mode.

$ solana find-program-derived-address -v 11111111111111111111111111111111 "string:HELLO"
Seeds: [[72, 69, 76, 76, 79]]
Bump: 255
4U64rfZFeEwSRmQdsNtMNRZtCD6w9b2QhrXgZzUoCDi6

@mergify mergify bot requested a review from a team September 30, 2024 21:30
@joncinque joncinque added the CI Pull Request is ready to enter CI label Oct 14, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Oct 14, 2024
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! It looks good to me -- there's just a clippy issue to resolve, then we should be able to merge this.

let seeds_slice = seeds.iter().map(|x| &x[..]).collect::<Vec<_>>();
let (address, bump_seed) = Pubkey::find_program_address(&seeds_slice[..], program_id);
let result = CliFindProgramDerivedAddress {
address: address.to_string(),
seeds: seeds.clone(),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy is complaining about the &Vec passed in, and saying to change that to &[_] instead: https://github.com/anza-xyz/agave/actions/runs/11114470308/job/31517664360?pr=3042#step:5:1336

And then this will need to change to seeds.to_owned()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants