Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Agave docs #2887

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Publish Agave docs #2887

merged 5 commits into from
Sep 11, 2024

Conversation

willhickey
Copy link

@willhickey willhickey commented Sep 10, 2024

Problem

Agave docs don't publish anywhere

Summary of Changes

Turn the docs publishing pipeline back on.

This is tricky to test properly without merging first. I've tested it from my dev server by running this:

#!/usr/bin/env bash

export VERCEL_TOKEN="***"
export VERCEL_SCOPE="***"
echo "Starting npm install"
npm install
echo "Starting ./build.sh"
./build.sh

Which produces builds here:
https://vercel.com/anza-tech/docs/deployments

Looking through .github/workflows/docs.yml, docs/build.sh, and docs/publish-docs.sh I think the old logic logic should still work. I'd like to merge this and test it in production. Once it's publishing correctly I can setup a DNS record for: edge.docs.anza.xyz

And then backport this PR (plus any follow ups) before setting up DNS records for:
beta.docs.anza.xyz
docs.anza.xyz

@yihau yihau added the v2.0 Backport to v2.0 branch label Sep 11, 2024
Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪖

Copy link

mergify bot commented Sep 11, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@willhickey willhickey merged commit 383b49f into anza-xyz:master Sep 11, 2024
12 checks passed
mergify bot pushed a commit that referenced this pull request Sep 11, 2024
* Add publish-docs.sh to build.sh

* Add debugging echos

* Fake being in CI

* Update vercel doc project names

* Remove debugging echos. Remove CI var.

(cherry picked from commit 383b49f)
Copy link

mergify bot commented Sep 13, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

mergify bot pushed a commit that referenced this pull request Sep 13, 2024
* Add publish-docs.sh to build.sh

* Add debugging echos

* Fake being in CI

* Update vercel doc project names

* Remove debugging echos. Remove CI var.

(cherry picked from commit 383b49f)
willhickey added a commit that referenced this pull request Sep 19, 2024
Publish Agave docs (#2887)

* Add publish-docs.sh to build.sh

* Add debugging echos

* Fake being in CI

* Update vercel doc project names

* Remove debugging echos. Remove CI var.

(cherry picked from commit 383b49f)

Co-authored-by: Will Hickey <will.hickey@anza.xyz>
willhickey added a commit that referenced this pull request Sep 19, 2024
Publish Agave docs (#2887)

* Add publish-docs.sh to build.sh

* Add debugging echos

* Fake being in CI

* Update vercel doc project names

* Remove debugging echos. Remove CI var.

(cherry picked from commit 383b49f)

Co-authored-by: Will Hickey <will.hickey@anza.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.18 v2.0 Backport to v2.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants