-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish Agave docs #2887
Publish Agave docs #2887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪖
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
* Add publish-docs.sh to build.sh * Add debugging echos * Fake being in CI * Update vercel doc project names * Remove debugging echos. Remove CI var. (cherry picked from commit 383b49f)
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
* Add publish-docs.sh to build.sh * Add debugging echos * Fake being in CI * Update vercel doc project names * Remove debugging echos. Remove CI var. (cherry picked from commit 383b49f)
Problem
Agave docs don't publish anywhere
Summary of Changes
Turn the docs publishing pipeline back on.
This is tricky to test properly without merging first. I've tested it from my dev server by running this:
Which produces builds here:
https://vercel.com/anza-tech/docs/deployments
Looking through
.github/workflows/docs.yml
,docs/build.sh
, anddocs/publish-docs.sh
I think the old logic logic should still work. I'd like to merge this and test it in production. Once it's publishing correctly I can setup a DNS record for: edge.docs.anza.xyzAnd then backport this PR (plus any follow ups) before setting up DNS records for:
beta.docs.anza.xyz
docs.anza.xyz