add ancient.total_alive_bytes metric #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
reviewed
Sep 4, 2024
| .map(|info| total_dead_bytes += info.capacity.saturating_sub(info.alive_bytes)) | ||
| .map(|info| { | ||
| total_dead_bytes += info.capacity.saturating_sub(info.alive_bytes); | ||
| total_alive_bytes += info.alive_bytes; |
There was a problem hiding this comment.
I was initially curious how we guaranteed slots was all the ancient storages, otherwise this wouldn't be a 'total', per se.
I see we get slots by calling AccountsDb::get_sorted_potential_ancient_slots(). I believe it is safe for this function to assume/require that slots is correct.
And assuming we use 'pack', then the stats are reported after each invocation of combine_ancient_slots_packed(), so I think that also ensures we don't sum up multiple 'totals' too.
jeffwashington
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ancient packing needs to know the # of alive bytes across all ancient storages for future optimizations, such as a dynamic ideal size.
Summary of Changes
Calculate and add a metric for all alive bytes across all ancient storages.
Fixes #