-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0: chore: bump curve25519-dalek from 3.2.1 to 4.1.3 (backport of #2252) #2817
Conversation
Cherry-pick of 6e23e69 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
why do we need to bump major on a dependency in beta? |
Backporting the dalek crate made sense a couple months ago, but given that 2.0 will hit mainnet in a little over a month, I think it makes sense to just include the version bump in 2.1. |
* bump curve25519-dalek from 3.2.1 to 4.1.3 * Update .github/scripts/downstream-project-spl-common.sh Co-authored-by: samkim-crypto <skim13@cs.stanford.edu> * Update .github/scripts/downstream-project-spl-common.sh Co-authored-by: samkim-crypto <skim13@cs.stanford.edu> * Update .github/scripts/downstream-project-spl-common.sh Co-authored-by: samkim-crypto <skim13@cs.stanford.edu> * Update Cargo.toml Co-authored-by: samkim-crypto <skim13@cs.stanford.edu> * remove opt level hack * add comment for opt level --------- Co-authored-by: samkim-crypto <skim13@cs.stanford.edu> (cherry picked from commit 6e23e69) # Conflicts: # Cargo.lock # Cargo.toml # programs/sbf/Cargo.lock
fa0eb04
to
33ea43f
Compare
@joncinque looks like the mainnet-beta will switch to v2.0 soon. do we still want to backport this one 🤔 |
Yeah, let's hold off on this backport. We should call out the breaking change in the 2.1 changelog though, since we have a breaking change between 2.0 and 2.1 🫠 |
Problem
we did this bump in #1693, but it seems like we have some concerns that broke the semver convention. I revered it in #2055.
Summary of Changes
try to bump it again
This is an automatic backport of pull request #2252 done by Mergify.