Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments of loader-v4 (part 2) #2750

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Aug 27, 2024

Problem

Continuation of #2630.

Summary of Changes

  • Splits TransferAuthority and Finalize into two instructions.
  • Adds next-version-forwarding to finalized programs.
  • Makes loader-v4 a program runtime v1 loader.

Copy link

mergify bot commented Aug 27, 2024

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso force-pushed the refactor/loader-v4 branch 8 times, most recently from 91585ba to 88a1a3e Compare August 27, 2024 13:14
@Lichtso Lichtso force-pushed the refactor/loader-v4 branch 8 times, most recently from 9160d94 to 441093a Compare August 28, 2024 05:01
@Lichtso Lichtso requested a review from pgarg66 August 28, 2024 07:56
Copy link

@pgarg66 pgarg66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits. Otherwise looks good.

cli/src/program_v4.rs Outdated Show resolved Hide resolved
programs/loader-v4/src/lib.rs Outdated Show resolved Hide resolved
@Lichtso Lichtso merged commit f6b7752 into anza-xyz:master Aug 29, 2024
52 checks passed
@Lichtso Lichtso deleted the refactor/loader-v4 branch August 29, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants