v2.0: Runtime: Core BPF: Add test for CPI post-migration (backport of #2531) #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
2501babe
approved these changes
Aug 19, 2024
(cherry picked from commit 8f675eb)
buffalojoec
force-pushed
the
mergify/bp/v2.0/pr-2531
branch
from
4d87741
to
c9ab6d4
Compare
CriesofCarrots
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our test suite for migrating builtin programs to BPF sends a transaction with an instruction for the newly migrated program, to test that it can be loaded and executed successfully. However, this test suite is missing a test for CPI'ing to this program.
Building on the back of #2483, we should have coverage for this case.
Summary of Changes
Add a mocked-out builtin processor designed to CPI to the provided program to the test suite. Then simply send a transaction to this builtin (like we're already doing with the newly migrated program) directing it to CPI to the newly migrated program.
This is an automatic backport of pull request #2531 done by [Mergify](https://mergify.com).