v2.0: fix: ensure vote packets can be retried (backport of #2605) #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit ecb44d7)
AshwinSekar
approved these changes
Aug 15, 2024
|
Are there any results with this change on a test cluster? |
|
Or put another way, with ~6wks before we intend to take 2.0 to mb, how will this change's efficacy be validated on testnet? |
|
Haven't tested on a test cluster, I think testing for a few weeks on testnet is both sufficient and safe given the nature of the bug and this fix. @AshwinSekar has been tracking vote latency in #1851 and we can track the impact with those same metrics. This is a clear bug that should be patched soon before TVC is enabled |
t-nelson
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Retryable vote packets are not retried so any votes received at the end of a block won't ever get processed by the current leader leading to higher voting latency
This is because when we try to reinsert retryable vote tx packets, the reinserted vote tx's will have timestamps equal to but not greater than the latest stored vote tx's timestamp. So the "taken" vote packet never gets replenished.
Summary of Changes
Allow replacing existing latest votes when the latest vote is "taken" and the slot and timestamps are equivalent to the replaced vote.
Fixes #
This is an automatic backport of pull request #2605 done by [Mergify](https://mergify.com).