Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unused-must-use #2490

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix unused-must-use #2490

merged 1 commit into from
Aug 9, 2024

Conversation

yihau
Copy link
Member

@yihau yihau commented Aug 8, 2024

(part of #2487)

Problem

Screenshot 2024-08-08 at 21 42 16

Summary of Changes

fix it

@yihau yihau marked this pull request as ready for review August 8, 2024 16:35
@yihau yihau requested a review from steviez August 8, 2024 16:35
steviez
steviez approved these changes Aug 8, 2024
View reviewed changes
Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable and println! instead of eprintln! is consistent with elsewhere in the file

@yihau yihau merged commit c20b1d6 into anza-xyz:master Aug 9, 2024
40 checks passed
@yihau yihau deleted the fix-unused-format branch August 9, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviez steviez steviez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihau @steviez