Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash-cache-tool: Refactors getting and parsing cache files #1973

Merged

Conversation

brooksprumo
Copy link

Problem

I want to reuse the code that gets, parses, and sorts all the cache files in a directory, but it is contained within another function. This prevents reuse.

Summary of Changes

Refactor it out to its own function.

@brooksprumo brooksprumo self-assigned this Jul 2, 2024
@brooksprumo brooksprumo marked this pull request as ready for review July 2, 2024 20:27
@brooksprumo brooksprumo requested a review from HaoranYi July 2, 2024 20:27
Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit 0ff5a4b into anza-xyz:master Jul 2, 2024
40 checks passed
@brooksprumo brooksprumo deleted the hash-cache-tool/get-cache-files branch July 2, 2024 22:34
samkim-crypto pushed a commit to samkim-crypto/agave that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants