SVM: Move protobuf into separate conformance crate #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
force-pushed
the
svm-conformance
branch
from
d872131
to
517f65c
Compare
LucasSte
previously approved these changes
Jul 2, 2024
buffalojoec
force-pushed
the
svm-conformance
branch
from
517f65c
to
194c8e4
Compare
|
Sorry @LucasSte I had to rebase to resolve conflicts. My code is unchanged. |
LucasSte
approved these changes
Jul 2, 2024
samkim-crypto
pushed a commit
to samkim-crypto/agave
that referenced
this pull request
Jul 31, 2024
* init svm-conformance crate * svm-conformance: add protos * svm: use svm-conformance for tests * svm: drop protos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The use of
prostand protobuf fixtures in the SVM crate's test suite depends on abuild script using
prost-build. Since Cargo doesn't currently offer a smooth way toadd test-only build scripts, this build script gets run whenever someone imports
solana-svm.The
prost-buildlibrary requires the host operating system to have the protobufcompiler installed in order to successfully execute the build script to build the protobuf
bindings.
Rather than impose this resource requirement on downstream users in their applications,
since we only use the protobuf bindings to test the SVM, we can instead extract them
into a separate crate for testing only.
Summary of Changes
Extract the protobuf files, the
prost-buildbuild script, and theprotomodule outof
solana-svmtests and into a new cratesolana-svm-conformance.Note the new crate is non-publish.