v1.18: gossip: do not allow duplicate proofs for incorrect shred versions (backport of #1931) #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
AshwinSekar
force-pushed
the
mergify/bp/v1.18/pr-1931
branch
from
a621f78
to
eda9c5b
Compare
AshwinSekar
force-pushed
the
mergify/bp/v1.18/pr-1931
branch
from
eda9c5b
to
8bf82e4
Compare
steviez
approved these changes
Jul 2, 2024
t-nelson
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Nodes that do not participate in a cluster restart can have old shreds with a previous shred version.
Upon restart they will create duplicate proofs using this old shred version and newly received shreds and propagate them to the rest of the cluster.
Summary of Changes
Disallow creation and consumption of duplicate proofs involving shreds with incorrect shred versions
This is an automatic backport of pull request #1931 done by [Mergify](https://mergify.com).