Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler opt-in forwarding #1801

Merged
merged 7 commits into from
Jul 12, 2024

Conversation

apfitzge
Copy link

Problem

  • In scheduler forward packets #898 we re-added forwarding to support those with swqos side-deals to use the central scheduler.
  • This behavior is useless for any operators using the central scheduler if they do not have such side-deals

Summary of Changes

  • SchedulerController is now configurable and can enable forwarding or not.
  • Add CLI argument enable-block-production-forwarding
    • this makes forwarding opt-in. Any operators with side-deals should enable this if they want it to actually do forwarding.

Fixes #

@apfitzge
Copy link
Author

Diff is not too bad, relatively easy to make this opt-in. cc @diman-io for awareness.

@t-nelson I think if we merge #1663 we should strongly consider backporting this immediately after.
This PR basically returns scheduler (by default) to the current behavior that is on MNB.

@apfitzge apfitzge marked this pull request as ready for review June 20, 2024 15:59
@apfitzge apfitzge requested a review from tao-stones June 20, 2024 16:01
validator/src/main.rs Outdated Show resolved Hide resolved
validator/src/main.rs Outdated Show resolved Hide resolved
@apfitzge apfitzge requested a review from t-nelson June 28, 2024 19:41
@apfitzge
Copy link
Author

apfitzge commented Jul 9, 2024

@t-nelson is there anything else to do here?

@apfitzge apfitzge force-pushed the scheduler_opt_in_forwarding branch from 631a88b to e172e8b Compare July 12, 2024 13:44
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me

@apfitzge apfitzge merged commit 61d8be0 into anza-xyz:master Jul 12, 2024
40 checks passed
@apfitzge apfitzge deleted the scheduler_opt_in_forwarding branch July 12, 2024 18:10
@apfitzge apfitzge added the v2.0 Backport to v2.0 branch label Jul 25, 2024
Copy link

mergify bot commented Jul 25, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Jul 25, 2024
(cherry picked from commit 61d8be0)
apfitzge added a commit that referenced this pull request Jul 25, 2024
(cherry picked from commit 61d8be0)
apfitzge added a commit that referenced this pull request Sep 12, 2024
* scheduler opt-in forwarding (#1801)

(cherry picked from commit 61d8be0)

* Scheduler: buffer packets for forwarding if forwarding is enabled (#2305)

---------

Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.0 Backport to v2.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants