SVM: change modified programs result to hash map #1391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the SVM's
TransactionResult
requires a full local program cacheinstance to return the programs modified by the transaction batch. This can
be done more elegantly with a hash map.
Furthermore, other crates who must mock out SVM transaction results can
now simply use
HashMap::new()
, and forego having to drag in types fromsolana-program-runtime
. This even removes the dependency from AccountsDBaltogether.
Summary of Changes
Change
programs_modified_by_tx
in the SVM'sTransactionResult
to be aHashMap<Pubkey, Arc<ProgramCacheEntry>>
.