v1.18: reverts back in SocketAddr dedup in retransmit stage (backport of #1106) #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
behzadnouri
added
the
automerge
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.18 #1225 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 827 827
Lines 225352 225364 +12
=========================================
- Hits 184043 184030 -13
- Misses 41309 41334 +25 |
|
@CriesofCarrots @sakridge mind taking a look? i approved the master pr |
CriesofCarrots
approved these changes
May 7, 2024
t-nelson
approved these changes
May 14, 2024
bw-solana
approved these changes
May 14, 2024
| node.contact_info()? | ||
| .tvu(protocol) | ||
| .ok() | ||
| .filter(|addr| addrs.get(addr) == Some(&node.pubkey())) |
There was a problem hiding this comment.
Comment explaining were deduping addresses would be nice
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
… of anza-xyz#1106) (anza-xyz#1225) reverts back in SocketAddr dedup in retransmit stage (anza-xyz#1106) This was erronously deemed as unnecessary and removed in: anza-xyz#864 The commit partially reverts anza-xyz#864 and adds back socket-addr dedup. (cherry picked from commit fbe1dbc) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This was erronously deemed as unnecessary and removed in: #864
Summary of Changes
The commit partially reverts #864 and adds back socket-addr dedup.
This is an automatic backport of pull request #1106 done by [Mergify](https://mergify.com).