-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: don't self-update rustup when using the rust-version script #1209
Conversation
This reverts commit b343e61.
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪖
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1209 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 886 886
Lines 236443 236443
=========================================
- Hits 194299 194287 -12
- Misses 42144 42156 +12 |
…t (backport of #1209) (#1215) ci: don't self-update rustup when using the rust-version script (#1209) * ci: don't update rustup when using the rust-version script * XXX: fake updates for triggering all * Revert "XXX: fake updates for triggering all" This reverts commit b343e61. (cherry picked from commit 206a87a) Co-authored-by: Yihau Chen <yihau.chen@icloud.com>
…t (backport of #1209) (#1214) ci: don't self-update rustup when using the rust-version script (#1209) * ci: don't update rustup when using the rust-version script * XXX: fake updates for triggering all * Revert "XXX: fake updates for triggering all" This reverts commit b343e61. (cherry picked from commit 206a87a) Co-authored-by: Yihau Chen <yihau.chen@icloud.com>
…t (backport of anza-xyz#1209) (anza-xyz#1215) ci: don't self-update rustup when using the rust-version script (anza-xyz#1209) * ci: don't update rustup when using the rust-version script * XXX: fake updates for triggering all * Revert "XXX: fake updates for triggering all" This reverts commit b343e61. (cherry picked from commit 206a87a) Co-authored-by: Yihau Chen <yihau.chen@icloud.com>
Problem
we have some issues with Windows pipelines when setting up Rust version.
context: https://discord.com/channels/428295358100013066/560503042458517505/1237118149510566011
I found an issue in rustup repo: rust-lang/rustup#3709
I think it's harmless to adopt the workaround as our standard process. (even a better idea )
Summary of Changes
add
--no-self-update
to rust-versionthe successful build: https://github.com/anza-xyz/agave/actions/runs/8979866592/job/24662583658?pr=1209