Update cost-tracker to return more updated costs after successful try_add call #1141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After successful
try_add(...)
call, it currently return the updated block cost onlyu; It'd be useful to also include updated costliest account cost in the return, so the call site can know after adding TransactionCost to cost track, which account it updated has highest units.One particular use case for that additional information is: when
Forwarder
decides which "batch" a forwardable packet should be placed into, it can look at its "costliest account cost", mod by each batch's account limit, to get the target batch index.Summary of Changes
UpdatedCosts
Result<UpdatedCosts>
instead ofResult<u64>
Fixes #