Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.18: forwarder uses working bank as filter (backport of #1129) #1136

Merged
merged 1 commit into from
May 9, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 1, 2024

Problem

  • Forwarder uses root_bank for checking transactions
  • This will cause non-rooted blockhashes to get filtered out

Summary of Changes

  • use working_bank instead

Fixes #


This is an automatic backport of pull request #1129 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner May 1, 2024 14:53
@mergify mergify bot requested a review from a team as a code owner May 1, 2024 14:53
@bw-solana
Copy link

Note: This problem was discovered when trying to fetch a blockhash with confirmed commitment level for the ping client. Latency jumped up because these transactions were getting filtered out by the staked node forwarder until the blockhash became rooted.

These changes were run on the ping staging staked node (3gG) and confirmed to resolve the ping latency issue:
image
In graph above, here is what was running:

  • Left side = using finalized blockhash. Good latency because nothing gets filtered
  • Middle = using confirmed blockhash. Bad latency because we filter transactions for ~10 seconds
  • Right = using confirmed blockhash. Good latency because filtering behavior was modified by this change.

@yihau yihau merged commit 83ca778 into v1.18 May 9, 2024
35 checks passed
@yihau yihau deleted the mergify/bp/v1.18/pr-1129 branch May 9, 2024 03:36
anwayde pushed a commit to firedancer-io/agave that referenced this pull request Jul 23, 2024
…) (anza-xyz#1136)

forwarder uses working bank as filter (anza-xyz#1129)

(cherry picked from commit 79ae84e)

Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants