v1.18: cli: Use --use-rpc flag correctly during program deployments (backport of #1008) #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
cli: Use --use-rpc flag correctly (cherry picked from commit 550f806)
CriesofCarrots
approved these changes
Apr 23, 2024
joncinque
added
the
automerge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.18 #1011 +/- ##
=========================================
- Coverage 81.6% 81.5% -0.1%
=========================================
Files 827 827
Lines 225094 225122 +28
=========================================
+ Hits 183680 183686 +6
- Misses 41414 41436 +22 |
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…backport of anza-xyz#1008) (anza-xyz#1011) cli: Use --use-rpc flag correctly during program deployments (anza-xyz#1008) cli: Use --use-rpc flag correctly (cherry picked from commit 550f806) Co-authored-by: Jon C <me@jonc.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As noticed in #928 (comment), the logic for
--use-rpcis unfortunately backwards, since it's creating the tpu client ifuse_rpcis true, when we only want to create it when it's false.Summary of Changes
Reverse the logic with a
!Big thanks to @amilkov3 for noticing and reporting this
This is an automatic backport of pull request #1008 done by [Mergify](https://mergify.com).