Skip to content

Commit

Permalink
Replace unbounded with bounded as single channel is used (#2646)
Browse files Browse the repository at this point in the history
We need the receiver to hold just one message so there is no need
to have an unbounded channel.
  • Loading branch information
ksolana authored Aug 22, 2024
1 parent 4cf51ba commit 35051c7
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions poh/src/poh_recorder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
use solana_ledger::genesis_utils::{create_genesis_config, GenesisConfigInfo};
use {
crate::{leader_bank_notifier::LeaderBankNotifier, poh_service::PohService},
crossbeam_channel::{unbounded, Receiver, RecvTimeoutError, SendError, Sender, TrySendError},
crossbeam_channel::{
bounded, unbounded, Receiver, RecvTimeoutError, SendError, Sender, TrySendError,
},
log::*,
solana_entry::{
entry::{hash_transactions, Entry},
Expand Down Expand Up @@ -207,7 +209,7 @@ impl TransactionRecorder {
transactions: Vec<VersionedTransaction>,
) -> Result<Option<usize>> {
// create a new channel so that there is only 1 sender and when it goes out of scope, the receiver fails
let (result_sender, result_receiver) = unbounded();
let (result_sender, result_receiver) = bounded(1);
let res =
self.record_sender
.send(Record::new(mixin, transactions, bank_slot, result_sender));
Expand Down

0 comments on commit 35051c7

Please sign in to comment.