Restore related videos, recommendations, and auto-play next functionality #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Player monitor was stopping immediately - This resulted in all play_data for a video being set to zero
- Youtube plugin will show up as a Program Addon as a consequence - TODO: Find out why the script is required - TODO: Make the script entry point more useful if required e.g. open settings from Program Addons
- Also make all sequences as tuples rather than lists
- Performing a Container.Update in the internal playlist window should be avoided
- Directory items now fixed in order added, regardless of sort order
- Provider.set_content_type was just a wrapper for XbmcContext methods with context passed as a parameter - Eliminate the redundant wrapper
- All datetime values are now stored internally as timezone aware objects with a UTC timezone - Local datetime values are now converted to timezone aware objects with a local timezone rather than using a fixed offset - Infolabels strip off microseconds and tzinfo as different Kodi getter/setter methods handle such values incorrectly - Old behaviour is retained for backwards compatibility - Fix (remove) incorrect empty string default fallback for lastplayed - Fix typo in format string for date infolabel used for Kodi 18 - Remove unnecessary datetime parsing for plugin_created_date
- Also removes some very old code targeting Frodo/Gotham
- This unfortunately doesn't prevent folder items having a 0 count value as Kodi sets that by default
- Only return tuple of output and processed input value when necessary
- Intended as a backup means to restore the Default sort order which is lost if another sort method is applied - Currently only applies to v3 API response items - Also remove some duplicated code
- Allow for retrieving multiple values using a slice path entry - Properly handle splitting/divergent paths
- video_id and access_token now need to be supplied as part of data parameter (along with anything else) of build_client method
- Partially fix anxdpanic#508 - TODO: Improve support of InnerTube requests to handle configured max_result number of results - TODO: Result is coerced into a V3 Data API result. Support native JSON result in ResourceManager
- Prevent unhandled AttributeError when accessing request reponse attributes, if response was not received
- Fix up bug introduced in 978312d while trying to maintain Python 2 compatibility
- yt_video originally used Container.Update directly - This was replaced by existing content_from_description menu item method - content_from_description used RunPlugin which will fail to load directory listing
- Should no longer be necessary when using common request module
- Dialogs were not being closed on errors and exceptions
- This is just a temporary measure until better thread management is implemented
- Use new Youtube.get_related_videos and local history - Fix anxdpanic#508
- Response object __bool__ method is wrapper for ok property - Add status code to JSON error details
- Follow up to b2be81a - Also test removal of check for search input prior to refresh - Should hopefully no longer be necessary after refactors
- Avoids the situation where actions can't be performed if the plugin can't start e.g. if access_manager.json is corrupt
- Fix for existing log_notice calls not showing up in Kodi 18 log
- Follow up to 2961cdc which bumped combined size from 10 MB to 20 MB
- Existing data will not be migrated and will be unused unless renamed and copied to new location
- Also ensure correct context menu items are added and pointed to right targets
- If account does not have history tracking enabled then no related videos will be retrieved
MoojMidge
force-pushed
the
wip-unstable
branch
5 times, most recently
from
b2a920e
to
0578fff
Compare
- Remove patch and use git directly
- Also improve parsing in general by attempting to pre-format input
- TODO: Rewrite YouTube.get_my_subscriptions with better error and thread handling
MoojMidge
force-pushed
the
wip-unstable
branch
from
0578fff
to
1f4c5ac
Compare
|
This is amazing, lots of work in this. Congratulations. |
|
Few updates to be made for cache and thread handling, but it works pretty well in comparison to my own manual viewing habits. |
|
Recomendations and Related Videos both work for me, but MySubscriptions crashes with a Python error. My setup is Raspberry Pi4, RPI Bookworm (Debian 12), Kodi Nexus 20.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
New:
Changed: