Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow null values for forge update mutation #37

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

ctmckenna
Copy link
Contributor

@ctmckenna ctmckenna commented Mar 19, 2021

Description of the change

default forge config has null values on finishPage. To
edit forge config without changing finishPage, we need to allow
those null values

Currently if any value is null graphQLUploadSchemaIsValid fails on line 20 when it tries to dereference schema to check if schema.constructor.name === 'Object'

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fixes #1

Checklists

Development

  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • No previous tests unrelated to the changed code fail in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • At least one reviewer has been requested
  • Changes have been reviewed by at least one other engineer
  • The relevant project board has been selected in Projects to auto-link to this pull request

default forge config has null values on finishPage.  To
edit forge config without changing finishPage, we need to allow
those null values
@newhouse newhouse self-requested a review March 25, 2021 23:20
@newhouse newhouse self-assigned this Mar 25, 2021
Copy link
Contributor

@newhouse newhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@newhouse newhouse merged commit e519c8c into anvilco:master Mar 31, 2021
@newhouse
Copy link
Contributor

This has been published in 2.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants