Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename send to draft (and flip the logic) in createEtchPacket #23

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

newhouse
Copy link
Contributor

@newhouse newhouse commented Sep 24, 2020

Description of the change

rename send to draft (and flip the logic) in createEtchPacket.

I have manually tested this against the changes in https://github.com/anvilco/anvil/pull/1632 and it works as expected.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Checklists

Development

  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • No previous tests unrelated to the changed code fail in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • At least one reviewer has been requested
  • Changes have been reviewed by at least one other engineer
  • The relevant project board has been selected in Projects to auto-link to this pull request

@newhouse newhouse merged commit 15b9c17 into master Sep 24, 2020
@newhouse newhouse deleted the newhouse/rename-send-to-draft-createEtchPacket branch September 24, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants