Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use module.exports instead of import/export #10

Merged
merged 2 commits into from
Mar 20, 2020
Merged

Use module.exports instead of import/export #10

merged 2 commits into from
Mar 20, 2020

Conversation

ralbayaty
Copy link
Contributor

Description of the change

We want to remove the dependence on babel since we only use it for import/export at the moment.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • No previous tests unrelated to the changed code fail in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • At least one reviewer has been requested
  • Changes have been reviewed by at least one other engineer
  • The relevant project board has been selected in Projects to auto-link to this pull request

@ralbayaty ralbayaty added enhancement New feature or request dependencies Pull requests that update a dependency file labels Mar 20, 2020
@ralbayaty ralbayaty requested a review from benogle March 20, 2020 22:15
@ralbayaty ralbayaty self-assigned this Mar 20, 2020
@benogle
Copy link
Contributor

benogle commented Mar 20, 2020

Noice: -1848

@ralbayaty ralbayaty merged commit 31e60b4 into master Mar 20, 2020
@ralbayaty ralbayaty deleted the ra-remove-babel branch March 20, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benogle benogle benogle approved these changes

Assignees

@ralbayaty ralbayaty

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralbayaty @benogle