Task 1 react components #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
anutaguzova
commented
Aug 31, 2021
anutaguzova
commented
- Task - https://github.com/rolling-scopes-school/tasks/blob/master/tasks/react/react-components.md
- Deploy https://task-1-react-components.netlify.app/
- задание выполнено: - сборка; - компоненты Card и Search bar
src/App.tsx
Outdated
| map: 'https://goo.gl/maps/abDoKFxqoc66ptWt5', | ||
| like: '850', | ||
| eye: '950', | ||
| }, |
Collaborator
There was a problem hiding this comment.
Необходимо вынести данные для карточек в отдельный файл, такие данные не хранятся в state
src/App.tsx
Outdated
| <Search /> | ||
| <div className="card-container"> | ||
| {this.state.card.map((card) => { | ||
| return <Card card={card} key={card.country + Math.random()} />; |
Collaborator
There was a problem hiding this comment.
Молодец что добавила key={card.country + Math.random()}, тем самым ты избавилась от ошибки в консоли. Но использование Math.random() плохая практика. Можно было добавить id к карточкам, но так тоже можно.
src/components/card.tsx
Outdated
| @@ -0,0 +1,35 @@ | |||
| export function Card(props) { | |||
Collaborator
There was a problem hiding this comment.
Стоит использовать деструктуризацию для props:
export function Card({card})
| "main": "index.js", | ||
| "scripts": { | ||
| "start": "webpack serve --config webpack/webpack.config.js --env env=dev", | ||
| "build": "webpack --config webpack/webpack.config.js --env env=prod", |
Collaborator
There was a problem hiding this comment.
Есть скрипт для prod сборки, но нет скрипта для dev сборки
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.