Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dark-vue theme. #427

Merged
merged 2 commits into from
Sep 6, 2020
Merged

Added dark-vue theme. #427

merged 2 commits into from
Sep 6, 2020

Conversation

mehtaabGill
Copy link
Contributor

Annotation 2020-08-26 172651

Good day. I created a 'dark-vue' theme and would like to share it with others.

@anuraghazra
Copy link
Owner

Theme preview (bot)

title-color: #41b883

icon-color: #41b883

text-color: #fffefe

bg-color: #273849

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #427 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files          17       17           
  Lines         526      526           
  Branches      143      143           
=======================================
  Hits          494      494           
  Misses         28       28           
  Partials        4        4           
Impacted Files Coverage Δ
themes/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e9f6ef...082930e. Read the comment docs.

@github-actions github-actions bot added the themes Feature, Enhancement, Fixes related to themes. label Aug 26, 2020
@anuraghazra
Copy link
Owner

wow oops, sorry we already have vue-dark theme

@mehtaabGill
Copy link
Contributor Author

Ah yes. I did see that but the colors on that theme were slightly inaccurate in my opinion, however, I will let you decide wether you would like it to be added or not.

@anuraghazra
Copy link
Owner

Ah yes. I did see that but the colors on that theme were slightly inaccurate in my opinion, however, I will let you decide wether you would like it to be added or not.

Well true, your are more accurate, maybe you can overwrite the old vue dark theme with your more accurate colors. instead of adding this new theme

@anuraghazra
Copy link
Owner

Theme preview (bot)

title-color: #41b883

icon-color: #41b883

text-color: #fffefe

bg-color: #273849

@mehtaabGill
Copy link
Contributor Author

I have just edited the old theme now to match the correct Vue.js colors.

@anuraghazra
Copy link
Owner

Awesome! thanks @mehtaabGill

@anuraghazra anuraghazra merged commit df04e7e into anuraghazra:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
themes Feature, Enhancement, Fixes related to themes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants