Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified so that the src/calculateRank.js link can be used on the repository main screen #3140

Closed
wants to merge 1 commit into from

Conversation

Yaminyam
Copy link

Modify the path to an absolute path so that you can use the link in other paths, such as the repository main screen.

@vercel
Copy link

vercel bot commented Aug 25, 2023

@Yaminyam is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the documentation Improvements or additions to documentation. label Aug 25, 2023
@Yaminyam Yaminyam changed the title Modified so that the src/calculateRank.js link can be used on the repository main screen Modified so that the src/calculateRank.js link can be used on the repository main screen Aug 25, 2023
Copy link
Collaborator

@qwerty541 qwerty541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yaminyam Thanks for opening pull request!

@rickstaa I think we can merge this pull request as temporary solution for #3066. Unfortunately this will not work in vscode locally and in browser when user on not master branch, but it is more important for this link to work on repository main screen. It is very rare situation when you need it somewhere else. What do you think?

@rickstaa
Copy link
Collaborator

It looks like #3067 fixed all relative links except vercel.json and src/calculaterank.js 🤔. This is a bug since they should add the blob/master prefix. I will contact the support. If they can't fix it, let's use an absolute link. The benefit of a relative link is that it works on all forks and branches.

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 12, 2023

@qwerty541, it just became a lot stranger. This bug is only present on GRS. See https://github.com/rickstaa/relative_md_links_file_bug?tab=readme-ov-file 🤔. Let's see what the GitHub support says about this.

@qwerty541
Copy link
Collaborator

@qwerty541, it just became a lot stranger. This bug is only present on GRS. See https://github.com/rickstaa/relative_md_links_file_bug?tab=readme-ov-file 🤔. Let's see what the GitHub support says about this.

@rickstaa Yeah, thats strange, i just checked if it works in another repository with same paths https://github.com/qwerty541/relative_md_links_file_bug/tree/qwerty541-patch-1. We also can test if it works in master branch if you are up to merge.

@rickstaa
Copy link
Collaborator

@qwerty541, it just became a lot stranger. This bug is only present on GRS. See https://github.com/rickstaa/relative_md_links_file_bug?tab=readme-ov-file 🤔. Let's see what the GitHub support says about this.

@rickstaa Yeah, thats strange, i just checked if it works in another repository with same paths https://github.com/qwerty541/relative_md_links_file_bug/tree/qwerty541-patch-1. We also can test if it works in master branch if you are up to merge.

Thanks for debugging! It appears to be a GitHub bug. See #3066 (comment).

@qwerty541
Copy link
Collaborator

Closing this in favour of #3389.

@Yaminyam Thanks for your efforts anyway.

@qwerty541 qwerty541 closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants