-
-
Notifications
You must be signed in to change notification settings - Fork 22.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Wakatime animation delay #2224
base: master
Are you sure you want to change the base?
Conversation
@raychanks is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
One more thing, should we reduce the animation delay for each item? The current value is 150ms per item, but for a long list of items such as this one will take ages to complete the whole animation. |
@raychanks Thanks for your contribution. 🚀 The index parameter should indeed be passed.
You are correct it is better to change the animation if we want to support long lists. 🤔 Feel free to suggest an improved animation schema. 👍🏻 You can find an example in the improved language animation (see #2197). |
Tried with a few different speeds: (Original is 150ms)
50ms looks reasonable to me, what do you think? |
I think for that long list, 50ms is the best. Alternatively, we could also make the item delay dependent on the length of the list. Meaning having a total animation time and dividing this by the number of items? |
That's a great idea! I will update it tomorrow. |
@raychanks Thanks for the update! I checked your changes, and I think it is a great improvement. 🚀 I think the animation is a bit slow when fewer than 5 languages are shown. Peek.2022-10-28.21-05.mp4Maybe we should add a faster animation when fewer than 5 languages are shown? 🤔 Further, I think it would be nice if the compact layout also had an animation. Maybe we can use #2197 as an example? screen-capture.webm |
86aafe8
to
8bc69e7
Compare
Closes #2223