Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wakatime animation delay #2224

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

raychanks
Copy link
Contributor

Closes #2223

@vercel
Copy link

vercel bot commented Oct 24, 2022

@raychanks is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@raychanks
Copy link
Contributor Author

One more thing, should we reduce the animation delay for each item? The current value is 150ms per item, but for a long list of items such as this one will take ages to complete the whole animation.

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 24, 2022

@raychanks Thanks for your contribution. 🚀 The index parameter should indeed be passed.

One more thing, should we reduce the animation delay for each item? The current value is 150ms per item, but for a long list of items such as this one will take ages to complete the whole animation.

You are correct it is better to change the animation if we want to support long lists. 🤔 Feel free to suggest an improved animation schema. 👍🏻 You can find an example in the improved language animation (see #2197).

@raychanks
Copy link
Contributor Author

Tried with a few different speeds: (Original is 150ms)

  • 150ms.mov
  • 100ms.mov
  • 50ms.mov
  • 25ms.mov

50ms looks reasonable to me, what do you think?

@rickstaa
Copy link
Collaborator

Tried with a few different speeds: (Original is 150ms)

  • 150ms.mov
  • 100ms.mov
  • 50ms.mov
  • 25ms.mov

50ms looks reasonable to me, what do you think?

I think for that long list, 50ms is the best. Alternatively, we could also make the item delay dependent on the length of the list. Meaning having a total animation time and dividing this by the number of items?

@raychanks
Copy link
Contributor Author

That's a great idea! I will update it tomorrow.

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 28, 2022

@raychanks Thanks for the update! I checked your changes, and I think it is a great improvement. 🚀 I think the animation is a bit slow when fewer than 5 languages are shown.

Peek.2022-10-28.21-05.mp4

Maybe we should add a faster animation when fewer than 5 languages are shown? 🤔

Further, I think it would be nice if the compact layout also had an animation. Maybe we can use #2197 as an example?

screen-capture.webm

@rickstaa rickstaa force-pushed the master branch 2 times, most recently from 86aafe8 to 8bc69e7 Compare January 21, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wakatime staggered animation is not working
2 participants