Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide_border in Top Lang #205

Closed

Conversation

SSARCandy
Copy link
Contributor

Add hide_border option in Top Languages component

@codecov
Copy link

codecov bot commented Jul 26, 2020

Codecov Report

Merging #205 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   95.07%   95.08%   +0.01%     
==========================================
  Files          15       15              
  Lines         406      407       +1     
  Branches      120      121       +1     
==========================================
+ Hits          386      387       +1     
  Misses         16       16              
  Partials        4        4              
Impacted Files Coverage Δ
api/top-langs.js 100.00% <ø> (ø)
src/renderTopLanguages.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d929e8b...b567342. Read the comment docs.

@anuraghazra
Copy link
Owner

Hi @SSARCandy thanks for the PR, we actually refactored the common rendering logic to a new Card.js class which would handle this automatically. see #260

@SSARCandy
Copy link
Contributor Author

cool, then I'll close this PR

@SSARCandy SSARCandy closed this Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants