-
-
Notifications
You must be signed in to change notification settings - Fork 22.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compact layout for top languages card #134 #179
Conversation
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
+ Coverage 94.76% 95.07% +0.30%
==========================================
Files 15 15
Lines 382 406 +24
Branches 114 120 +6
==========================================
+ Hits 362 386 +24
Misses 16 16
Partials 4 4
Continue to review full report at Codecov.
|
Hi @sagar-gavhane thanks for the PR. |
Hmmm i see so in the screenshot it looks like the most used language php is at the end of the progress bar but it should be reversed. first PHP, then HTML, then all other langs |
…adme-stats into sagar-gavhane-task/134
@sagar-gavhane Also the theming system is broken right now since you did not take the colors intro consideration. /api/top-langs?username=anuraghazra&layout=compact&theme=dark EDIT: Oh it's because you missed the border-bg rect |
…nested svgs and height set
Hey @anuraghazra, somehow I've fixed border-radius on the lang progress bar. Could you please take a look at PR? |
…adme-stats into sagar-gavhane-task/134
Hi @sagar-gavhane Thanks for the PR, this looks good to me although it needs a bit of refactoring (code kinda looks messy rn) will do it later tho. Thanks! |
What type of PR is this? (check all applicable)
Pull request checklist
Please check if your PR fulfills the following requirements:
Description
Compact layout for top languages card similar to GitHub's lang card.
Related Tickets & Documents
#134
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added tests?
Does this introduce a breaking change?