Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support keep top language #176

Closed
wants to merge 4 commits into from

Conversation

leavesster
Copy link
Contributor

  1. add top parameter to keep top number languages.
  2. add EN and CH README.
  3. remove duplicate parameters.

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #176 into master will decrease coverage by 0.23%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   94.75%   94.51%   -0.24%     
==========================================
  Files          15       15              
  Lines         381      383       +2     
  Branches      114      115       +1     
==========================================
+ Hits          361      362       +1     
- Misses         16       17       +1     
  Partials        4        4              
Impacted Files Coverage Δ
api/top-langs.js 100.00% <ø> (ø)
src/renderTopLanguages.js 97.22% <50.00%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f355f48...a3297d2. Read the comment docs.

@anuraghazra
Copy link
Owner

Hi @leavesster we already have hiding specific languages option implemented in #150 so hiding top languages is not needed anymore. we previously had "hide_langs_below" option to hide langs below certain threshold but we already deprecated it for the same reason.

@leavesster
Copy link
Contributor Author

I just want to keep top languages no matter what language they are. I know hide specific languages can do it too, I just want to make it more simple, but it's true that top languages changes slow.

@leavesster leavesster closed this Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants