-
-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rose pine/master rebase #1605
rose pine/master rebase #1605
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/github-readme-stats-team/github-readme-stats/4WEwzRbVaxV6QqQ6iYAzKreSUSSU |
Automated Theme Preview title_color: Hi, thanks for the theme contribution, please read our theme contribution guidelines. We are currently only accepting color combinations from any VSCode theme or themes which have good color combination to minimize bloating the themes collection.
|
Codecov Report
@@ Coverage Diff @@
## master #1605 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 22 22
Lines 752 752
Branches 205 205
=======================================
Hits 713 713
Misses 35 35
Partials 4 4
Continue to review full report at Codecov.
|
@ThatOneCalculator I think this PR now is ready to be merged since your theme is not a VSCode theme, I first want to have this approved by @anuraghazra to prevent cluttering of the theme database. I, however, think the theme is distinct enough from the themes we already have https://github.com/anuraghazra/github-readme-stats/blob/master/themes/README.md. |
@ThatOneCalculator Thanks again for your contribution. I merged this since it is distinct from the other themes we already have, and your theme was highly requested. Maybe you can create a Vscode theme for it too? |
It's been a VSCode theme for a while 😁 |
Looks beautiful! Thanks @ThatOneCalculator |
@rickstaa @anuraghazra |
@ThatOneCalculator Thanks for letting us know. We just merged the pull request that the GA created for that (see #1632). |
Also, it's now on https://rosepinetheme.com/themes ! |
@ThatOneCalculator That's great. I think your theme is a great addition to our little tool. |
* Update index.js * Update index.js * Update index.js * Update index.js Co-authored-by: Kainoa Kanter <44733677+ThatOneCalculator@users.noreply.github.com>
* Update index.js * Update index.js * Update index.js * Update index.js Co-authored-by: Kainoa Kanter <44733677+ThatOneCalculator@users.noreply.github.com>
This is #892 rebased on the current master branch.