Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rose pine/master rebase #1605

Merged
merged 4 commits into from
Mar 5, 2022
Merged

rose pine/master rebase #1605

merged 4 commits into from
Mar 5, 2022

Conversation

rickstaa
Copy link
Collaborator

This is #892 rebased on the current master branch.

@vercel
Copy link

vercel bot commented Feb 20, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/github-readme-stats-team/github-readme-stats/4WEwzRbVaxV6QqQ6iYAzKreSUSSU
✅ Preview: https://github-readme-stats-git-rose-pi-96a8a6-github-readme-stats-team.vercel.app

@github-actions github-actions bot added the themes Feature, Enhancement, Fixes related to themes. label Feb 20, 2022
@anuraghazra
Copy link
Owner

Automated Theme Preview

title_color: #9ccfd8 | icon_color: #ebbcba | text_color: #e0def4 | bg_color: #191724

Preview Link

Hi, thanks for the theme contribution, please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes which have good color combination to minimize bloating the themes collection.

Also note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection you can use card customization options

@rickstaa rickstaa mentioned this pull request Feb 20, 2022
@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #1605 (1f8cfc8) into master (8b9f931) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1605   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files          22       22           
  Lines         752      752           
  Branches      205      205           
=======================================
  Hits          713      713           
  Misses         35       35           
  Partials        4        4           
Impacted Files Coverage Δ
themes/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b9f931...1f8cfc8. Read the comment docs.

@rickstaa rickstaa requested a review from anuraghazra February 20, 2022 17:09
@rickstaa
Copy link
Collaborator Author

@ThatOneCalculator I think this PR now is ready to be merged since your theme is not a VSCode theme, I first want to have this approved by @anuraghazra to prevent cluttering of the theme database.

I, however, think the theme is distinct enough from the themes we already have https://github.com/anuraghazra/github-readme-stats/blob/master/themes/README.md.

@rickstaa rickstaa merged commit 00b0913 into master Mar 5, 2022
@rickstaa rickstaa deleted the rose-pine/master-rebase branch March 5, 2022 08:00
@rickstaa
Copy link
Collaborator Author

rickstaa commented Mar 5, 2022

@ThatOneCalculator Thanks again for your contribution. I merged this since it is distinct from the other themes we already have, and your theme was highly requested. Maybe you can create a Vscode theme for it too?

@ThatOneCalculator
Copy link
Contributor

@ThatOneCalculator Thanks again for your contribution. I merged this since it is distinct from the other themes we already have, and your theme was highly requested. Maybe you can create a Vscode theme for it too?

It's been a VSCode theme for a while 😁
Just search Rosé Pine in extensions

@ThatOneCalculator
Copy link
Contributor

Also, https://rosepinetheme.com

@anuraghazra
Copy link
Owner

Looks beautiful! Thanks @ThatOneCalculator

@ThatOneCalculator
Copy link
Contributor

@rickstaa
Copy link
Collaborator Author

rickstaa commented Mar 6, 2022

@ThatOneCalculator Thanks for letting us know. We just merged the pull request that the GA created for that (see #1632).

@ThatOneCalculator
Copy link
Contributor

Also, it's now on https://rosepinetheme.com/themes !

@rickstaa
Copy link
Collaborator Author

rickstaa commented Mar 7, 2022

@ThatOneCalculator That's great. I think your theme is a great addition to our little tool.

Kab1r pushed a commit to Kab1r/github-readme-stats that referenced this pull request Apr 4, 2022
* Update index.js

* Update index.js

* Update index.js

* Update index.js

Co-authored-by: Kainoa Kanter <44733677+ThatOneCalculator@users.noreply.github.com>
lencx pushed a commit to lencx/github-readme-stats that referenced this pull request May 16, 2022
* Update index.js

* Update index.js

* Update index.js

* Update index.js

Co-authored-by: Kainoa Kanter <44733677+ThatOneCalculator@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
themes Feature, Enhancement, Fixes related to themes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants