Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cards): added typings for cards and fetchers #1596

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Conversation

anuraghazra
Copy link
Owner

  • TODO: Refactor types
  • TODO: Organize types

@vercel
Copy link

vercel bot commented Feb 17, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/github-readme-stats-team/github-readme-stats/6rTGDFkorghzaJKcdUFCRisNoBHo
✅ Preview: https://github-readme-stats-git-more-types-github-readme-stats-team.vercel.app

@anuraghazra anuraghazra requested a review from rickstaa February 17, 2022 15:58
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1596 (c73cbf6) into master (36aeb5c) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1596      +/-   ##
==========================================
- Coverage   94.81%   94.59%   -0.22%     
==========================================
  Files          22       22              
  Lines         752      759       +7     
  Branches      205      205              
==========================================
+ Hits          713      718       +5     
- Misses         35       37       +2     
  Partials        4        4              
Impacted Files Coverage Δ
api/pin.js 88.88% <ø> (ø)
src/cards/repo-card.js 100.00% <ø> (ø)
src/common/utils.js 98.16% <ø> (ø)
src/fetchers/repo-fetcher.js 95.83% <ø> (ø)
src/fetchers/top-languages-fetcher.js 100.00% <ø> (ø)
src/fetchers/wakatime-fetcher.js 90.90% <ø> (ø)
src/getStyles.js 56.25% <ø> (ø)
src/cards/stats-card.js 100.00% <100.00%> (ø)
src/cards/top-languages-card.js 100.00% <100.00%> (ø)
src/cards/wakatime-card.js 98.76% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36aeb5c...c73cbf6. Read the comment docs.

@rickstaa
Copy link
Collaborator

Great! Looks like a handy addition. I will review this later this month. Feel free to ping me if I forget.

@anuraghazra anuraghazra marked this pull request as ready for review February 23, 2022 14:44
@anuraghazra anuraghazra merged commit d57251c into master Feb 23, 2022
@anuraghazra anuraghazra deleted the more-types branch February 23, 2022 14:45
Kab1r pushed a commit to Kab1r/github-readme-stats that referenced this pull request Apr 4, 2022
* refactor(cards): added typings for cards and fetchers

* chore: move types to separate file
lencx pushed a commit to lencx/github-readme-stats that referenced this pull request May 16, 2022
* refactor(cards): added typings for cards and fetchers

* chore: move types to separate file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants