Fixed Firefox text overflow issue #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests currently don't work becouse it appears that '@supports' is not supported by cssToObject used within the tests. I currently have no idea how to fix that test but the cards themself appear to not be broken Fixes anuraghazra#664 Fixes anuraghazra#1134
|
@Electrenator is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
Electrenator
changed the title
|
@Electrenator thanks for the PR, can you try using this cssToObject library instead? https://www.npmjs.com/package/@uppercod/css-to-object It should work. |
Moved the `css-to-object` package to @UpperCod's version for test fix. This doesn't seem to have the same issues as the older package
Thank you for the other library. That one doesn't seem to have any problems with the used css elements at all. The tests now also work again. The stats should now look like this: |
Codecov Report
@@ Coverage Diff @@
## master #1492 +/- ##
=======================================
Coverage 94.68% 94.68%
=======================================
Files 22 22
Lines 752 752
Branches 205 205
=======================================
Hits 712 712
Misses 36 36
Partials 4 4
Continue to review full report at Codecov.
|
kvdomingo
pushed a commit
to kvdomingo/github-readme-stats
that referenced
this pull request
Jan 29, 2022
* Fixed Firefox text overflow / overwriting issue Tests currently don't work becouse it appears that '@supports' is not supported by cssToObject used within the tests. I currently have no idea how to fix that test but the cards themself appear to not be broken Fixes anuraghazra#664 Fixes anuraghazra#1134 * Fixed tests by moving to other css-to-object Moved the `css-to-object` package to @UpperCod's version for test fix. This doesn't seem to have the same issues as the older package * chore: cleanup test Co-authored-by: Anurag <hazru.anurag@gmail.com>
Kab1r
pushed a commit
to Kab1r/github-readme-stats
that referenced
this pull request
Apr 4, 2022
* Fixed Firefox text overflow / overwriting issue Tests currently don't work becouse it appears that '@supports' is not supported by cssToObject used within the tests. I currently have no idea how to fix that test but the cards themself appear to not be broken Fixes anuraghazra#664 Fixes anuraghazra#1134 * Fixed tests by moving to other css-to-object Moved the `css-to-object` package to @UpperCod's version for test fix. This doesn't seem to have the same issues as the older package * chore: cleanup test Co-authored-by: Anurag <hazru.anurag@gmail.com>
lencx
pushed a commit
to lencx/github-readme-stats
that referenced
this pull request
May 16, 2022
* Fixed Firefox text overflow / overwriting issue Tests currently don't work becouse it appears that '@supports' is not supported by cssToObject used within the tests. I currently have no idea how to fix that test but the cards themself appear to not be broken Fixes anuraghazra#664 Fixes anuraghazra#1134 * Fixed tests by moving to other css-to-object Moved the `css-to-object` package to @UpperCod's version for test fix. This doesn't seem to have the same issues as the older package * chore: cleanup test Co-authored-by: Anurag <hazru.anurag@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the Firefox overflow issues linked within this description. Both the tests and the cards should work like intended but now without text overflow issue within Firefox.
Tests currently don't work because it appears that@supportsis not supported by cssToObject used within the tests. I currently have no idea how to fix that test but the cards themself should work.Fixes #664
Fixes #1134