Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme names to README theme section #112

Closed
nombrekeff opened this issue Jul 20, 2020 · 8 comments
Closed

Add theme names to README theme section #112

nombrekeff opened this issue Jul 20, 2020 · 8 comments
Labels
documentation Improvements or additions to documentation.

Comments

@nombrekeff
Copy link
Contributor

Hey there!

Is your feature request related to a problem? Please describe.
I just tried the themes, but I had to try every theme to get the one I liked.

Describe the solution you'd like
I would suggest adding the name of the theme next/on top of the image, so it's easier to know which image corresponds to what theme.

PD: I can do this if accepted.

@anuraghazra anuraghazra added the documentation Improvements or additions to documentation. label Jul 20, 2020
@anuraghazra
Copy link
Owner

Hmmm i see yes. you can probably help it out :D thanks!

@nombrekeff
Copy link
Contributor Author

Yeah sure, I will work something out later.

What do you think if we create another MD file containing a table with all available themes with preview and name? But leave some previews in the main readme.

@anuraghazra
Copy link
Owner

Yeah thats what i was exactly thinking

@nombrekeff
Copy link
Contributor Author

Okay, I will do that then.

Do you prefer it if I create the new file in the root or inside the themes folder?

@nombrekeff
Copy link
Contributor Author

nombrekeff commented Jul 20, 2020

Also, do you have screenshots for each theme? I can do them myself if not.

I thought about adding the preview itself, but thought it might consume quota each time people looked at the themes.

@anuraghazra
Copy link
Owner

@nombrekeff we can probably just use live previews, it won't matter too much.

@nombrekeff
Copy link
Contributor Author

Okay, that will look cooler like this, and when/if we implement the custom cache max-age, we could add a long cache to that.

@nombrekeff
Copy link
Contributor Author

This was added in #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation.
Projects
None yet
Development

No branches or pull requests

2 participants