Themes preview #115
Merged
Themes preview #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks super nice, just don't make categories of dark / light themes just put them all at one place. :) |
|
Sure, I was not sure about that neither |
|
Also link the theme/README.md file from the main readme |
anuraghazra
reviewed
Jul 20, 2020
nombrekeff
commented
Jul 20, 2020
| @@ -83,7 +83,7 @@ dark, radical, merko, gruvbox, tokyonight, onedark, cobalt, synthwave, highcontr | |||
|
|
|||
| <img src="https://res.cloudinary.com/anuraghazra/image/upload/v1595174536/grs-themes_l4ynja.png" alt="Github Readme Stat Themes" width="600px"/> | |||
|
|
|||
| Check out more themes at [theme config file](./themes/index.js) & **you can also contribute new themes** if you like :D | |||
| You can look at a preview for [all available themes](./themes/README.md) or checkout the [theme config file](./themes/index.js) & **you can also contribute new themes** if you like :D | |||
There was a problem hiding this comment.
Link is already in the main readme, but I can change the text if you want
|
I've removed the Dark/Light groups, I like it more like that! |
|
Looks awesome! thanks @nombrekeff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
./themes/README.mdcontaining a table with a preview of all available themes alongside its name.I've added themes previews for both the stats and the repo card, and for light and dark themes.
You can see it live here
What do you guys think? Anything you would like to add?