feat: add cosine similarity algorithm #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Yanyan-Wang
reviewed
Sep 11, 2023
| @param targetItem - The target element. | ||
| @returns The cosine similarity between the item and the targetItem. | ||
| */ | ||
| const cosineSimilarity = ( |
Contributor
There was a problem hiding this comment.
nodes-cosine-similarity 也可以一起提～
Yanyan-Wang
reviewed
Sep 11, 2023
| import { clone } from '@antv/util'; | ||
| import { getAllProperties, oneHot } from './utils'; | ||
| import { NodeSimilarity } from './types'; | ||
| import { cosineSimilarity } from '.'; |
Contributor
There was a problem hiding this comment.
import { cosineSimilarity } from './cosine-similarity';
这样引入吧。从 index 容易出现循环引用
packages/graph/src/types.ts
Outdated
|
|
||
| export type NodeID = string | number; | ||
| export type NodeID = string | number; | ||
| export interface NodeSimilarity extends Node<{ [key: string]: any }> { |
Contributor
There was a problem hiding this comment.
好像应该 extends 的是 NodeData。Node 结构是 { id: ID, data: NodeData }。这些属性应该放在 NodeData 里面
Yanyan-Wang
approved these changes
Sep 12, 2023
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
algo: cos-similarity