Skip to content

Conversation

orientMoon
Copy link
Contributor

@orientMoon orientMoon commented Apr 25, 2024

Description

节点tools附着在节点元素上时,tools在计算matrix的tx、ty时需要以节点为原点

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 10.29%. Comparing base (bdfdadd) to head (3d9215a).

Files with missing lines Patch % Lines
packages/x6/src/registry/tool/button.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4276   +/-   ##
=======================================
  Coverage   10.29%   10.29%           
=======================================
  Files         180      180           
  Lines       10620    10620           
  Branches     2590     2590           
=======================================
  Hits         1093     1093           
  Misses       9438     9438           
  Partials       89       89           
Flag Coverage Δ
x6 10.29% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/x6/src/registry/tool/button.ts 10.44% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@antvis antvis deleted a comment from x6-bot bot Jul 22, 2025
@hustcc
Copy link
Member

hustcc commented Aug 12, 2025

@orientMoon 这个有相关的 issue 嘛,可以关联起来。

另外麻烦再 pr 描述中,增加一下前后的对照 gif。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants