-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: support virtual render with scroller plugin #4243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4243 +/- ##
=======================================
Coverage 10.29% 10.29%
=======================================
Files 180 180
Lines 10620 10620
Branches 2590 2590
=======================================
Hits 1093 1093
Misses 9438 9438
Partials 89 89
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
0caeaa4
to
4ed35c7
Compare
@OpportunityLiu 这个 PR 改动比较多,可以在描述中增加一些问题描述,结局思路,以及前后对照的 gif 嘛? |
这不就吧 scroll 的视口计算和变化事件暴露出去,然后就和普通的 virtual 没啥区别吗? 截图也看不出来啥吧 |
反正我们就靠这些顶到 10k 节点的 https://cloudpss.net/dslab/diagram?simu_id=0be31156-f28a-49b6-aa87-3159f6 但是这里面改的可就不止这点了,整个 renderer 我都全重写了 |
看起来改动代码不少啊,现在也没有单元测试,有点不放心🤦♂️ |
感觉这个优化很有价值啊,之前内部做 x6 和 react flow 的性能对比,没啥优势啊~ |
思路参考:#2988 |
Description
Motivation and Context
#3669
Types of changes
Self Check before Merge