-
Notifications
You must be signed in to change notification settings - Fork 220
feat: 树状平铺grid-tree模式,可以在Grid模式下展开/折叠 #3299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
|
你好 @Alexzjt,非常感谢你的贡献. Hello, @Alexzjt, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes. |
Summary of ChangesHello @Alexzjt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
此拉取请求引入了新的“树状平铺(grid-tree)”模式,它结合了平铺布局和展开/折叠功能。更改包括更新类型定义、在 RowCell 中实现新的渲染逻辑以处理折叠节点、在 PivotDataSet 中处理数据聚合,以及添加新的层级构建器。文档和示例也已相应更新。总体而言,这是一项功能完善且经过深思熟虑的实现。
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## next #3299 +/- ##
==========================================
+ Coverage 75.77% 78.81% +3.04%
==========================================
Files 257 224 -33
Lines 11994 12420 +426
Branches 2464 2801 +337
==========================================
+ Hits 9088 9789 +701
+ Misses 1398 946 -452
- Partials 1508 1685 +177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Size Change: +1.6 kB (+0.22%) Total Size: 727 kB
ℹ️ View Unchanged
|
👀 PR includes
✨ Feature
🎨 Enhance
🐛 Bugfix
🔧 Chore
📝 Description
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge