Skip to content

Conversation

@balabalabalading
Copy link
Contributor

@balabalabalading balabalabalading commented Jan 6, 2026

为 sequence 序列添加了漏斗模板

image image

Copilot AI review requested due to automatic review settings January 6, 2026 10:46
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @balabalabalading, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求引入了一个全新的 SequenceFunnel 结构及其配套模板,旨在为序列数据提供一种直观的分层漏斗可视化方式。它允许用户在左侧渲染分层漏斗形状,并在右侧显示对应的项目卡片和图标,从而增强了库在展示流程或层级数据方面的能力。

Highlights

  • 新增漏斗结构: 引入了 SequenceFunnel 组件,用于以漏斗形状可视化序列数据。
  • 结构注册与导出: 在 src/designs/structures/index.ts 中导出了 SequenceFunnel,并将其注册到结构注册表中,使其成为可用的可视化结构。
  • 内置模板支持: 在 src/templates/built-in.ts 中添加了一个名为 sequence-funnel-simple 的新内置模板,以便用户可以快速应用和使用新的漏斗结构。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 新增了 sequence-funnel 结构及其模板,实现很清晰,通过计算梯形分段来构造漏斗形状的逻辑也很巧妙。代码整体结构良好。我发现了一些可以改进的地方,主要关于“魔术数字”、代码重复以及一个潜在的 SVG ID 生成 bug。总的来说,这是一次很棒的贡献!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new sequence-funnel structure for creating funnel visualizations in the infographic system. The funnel displays items in a tapering layout from top to bottom, with trapezoid shapes on the left and corresponding item cards on the right.

Key Changes:

  • Added new SequenceFunnel component with configurable funnel shape parameters
  • Registered the sequence-funnel-simple template for easy usage
  • Exported the new structure from the structures index

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 11 comments.

File Description
src/designs/structures/sequence-funnel.tsx New component implementing the funnel structure with trapezoid segments, gradient fills, icons, and item cards
src/templates/built-in.ts Registered new sequence-funnel-simple template configuration
src/designs/structures/index.ts Added export for the new sequence-funnel structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hustcc
Copy link
Member

hustcc commented Jan 6, 2026

@balabalabalading 👍🏻 pr 描述中加一些截图示意吧~

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 15.46961% with 153 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.15%. Comparing base (7eac9c1) to head (2783e77).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/designs/structures/sequence-funnel.tsx 10.00% 153 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   31.03%   31.15%   +0.11%     
==========================================
  Files         319      321       +2     
  Lines       24271    24787     +516     
  Branches     1275     1326      +51     
==========================================
+ Hits         7533     7722     +189     
- Misses      16735    17062     +327     
  Partials        3        3              
Flag Coverage Δ
infographic 31.15% <15.46%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/designs/structures/index.ts 100.00% <100.00%> (ø)
src/templates/built-in.ts 100.00% <100.00%> (ø)
src/designs/structures/sequence-funnel.tsx 10.00% <10.00%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Aarebecca
Copy link
Contributor

@balabalabalading 非常感谢贡献,对于已经解决的 CR 问题,可以先点下 Resolve Conversation 🎉

@Aarebecca
Copy link
Contributor

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

你好,感谢你的贡献!这个 PR 添加了 sequence-funnel 结构及其模板,整体实现得很好,代码结构清晰。

我主要在 sequence-funnel.tsx 文件中发现了一些可以改进的地方,以提高代码的可读性和可维护性。具体来说,我建议将用于生成各图层元素的 forEach 循环重构为使用 map 函数,这样可以使代码更加函数式和声明式。

具体的修改建议请见我的评论。除此之外,其他文件的修改没有问题。

@balabalabalading
Copy link
Contributor Author

Gemini 首次 review 的问题,我已经修复过,点击了 Resolve conversation。
第二次 review 提出的是代码结构优化的问题,是否还需要处理?

@Aarebecca
Copy link
Contributor

Gemini 首次 review 的问题,我已经修复过,点击了 Resolve conversation。 第二次 review 提出的是代码结构优化的问题,是否还需要处理?

我来处理吧

@Aarebecca Aarebecca merged commit b2febdc into antvis:main Jan 7, 2026
1 check passed
@Aarebecca
Copy link
Contributor

@balabalabalading 感谢贡献,我们会在今天晚点发布版本,到时候可以上线使用

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants