-
Notifications
You must be signed in to change notification settings - Fork 274
chore: correct release workflow zip path #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Aarebecca
commented
Jan 4, 2026
- Correct Release workflow zip path
Summary of ChangesHello @Aarebecca, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a minor but important chore by correcting the extraction path for a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request corrects the path used in the tar command for extracting skills, removing a redundant ./. The change is applied consistently across the README files and the AI Playground component. While this is a good correction, I've also suggested a further improvement to enhance the script's robustness by using the unzip command, which is the standard tool for handling .zip archives, instead of tar.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly replaces the tar command with unzip for extracting the skills.zip archive in documentation and code snippets. This change is valid and necessary.
While reviewing, I identified a related high-severity issue in the script that could prevent it from working. The BASE_URL used for the download URL appears incorrect for fetching a GitHub release asset, which will likely cause the download to fail. To make the script more robust, I'd also suggest adding the --fail flag to curl and the -q (quiet) flag to unzip.
Since these issues are on lines not modified in this pull request, I'm providing the feedback in this summary. I highly recommend updating the script to ensure it's functional for users. A corrected version might look like this:
set -e
VERSION=0.2.4 # Replace <VERSION> with the latest tag, e.g. v0.2.4
BASE_URL=https://github.com/antvis/Infographic/releases/download
mkdir -p .claude/skills
curl -L --fail -o skills.zip "$BASE_URL/$VERSION/skills.zip"
unzip -q -o skills.zip -d .claude/skills
rm -f skills.zipeea6bba to
be9702d
Compare